429 propagate context to reneder param type correctly #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ab14af
to
6196cac
Compare
myazinn
commented
Apr 25, 2023
| @@ -43,71 +43,71 @@ abstract class ModulePatternAccessiblePolyTestBase(injectAlias: Boolean) extends | |||
|
|
|||
| def test_generates_accessor_function_for_field_of_the_polymorphic_service(): Unit = | |||
| assertEquals( | |||
| s"def v[R, T <: Example.Foo]: zio.ZIO[$aliasOrHasService with R, Throwable, T] = " + | |||
| s"def v[R, T <: Foo]: zio.ZIO[$aliasOrHasService with R, Throwable, T] = " + | |||
There was a problem hiding this comment.
Still compiles just fine. I guess it was a workaround for a bug rather than a feature
6196cac
to
5e3ba64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #429
Though I have no idea how to write a test for it ¯\_(ツ)_/¯ It looks like it breaks only when
package objectis placed in a separate file