Generate maps for additional properties in OpenAPI code gen (#2901) #2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3a5344
to
cdb90a6
Compare
jdegoes
approved these changes
Jun 19, 2024
hochgi
reviewed
Jun 20, 2024
Comment on lines
+932
to
+933
| // properties.isEmpty && additionalProperties.isRight | ||
| throw new IllegalArgumentException("Top-level maps are not supported") |
There was a problem hiding this comment.
@987Nabil why not actually?
If we want to derive an endpoint of a type like: Endpoint[Unit, Unit, Nothing, Map[String, String], None],
how should we go about to do so?
There was a problem hiding this comment.
This type would then need to be generated inline. But this code is for generating a file, not an inline type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2901
/claim #2901