-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept nested partials #50
Labels
enhancement
New feature or request
Comments
That makes a lot of sense and would also make our code simpler. To add to your observations, we also need to introduce a helper type - export function createUserMock(props: Partial<User>): User {
+ export function createUserMock(props: DeepPartial<User>): User {
} We can probably take the implementation from ts-essentials/ts-essentials or sindresorhus/type-fest. The simpler the better I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Another DX improvement idea, what I have in the code now is similar to this:
What would be more convenient and much less verbose is if the factory function accepted a nested partial param, like
but currently it requires me to pass all the data necessary for the operation mock. I would need to add missing
__typename
and all other fields that are selected even if the example/story/test doesn't care about them.The factories are already kinda recursive, it shouldn't require drastic changes.
Tricky cases that I anticipate:
__typename
would need to be requiredThe text was updated successfully, but these errors were encountered: