[WIP] Add parsing of lexical numbers #462
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured I would submit a WIP pull request to get your opinion on it, before I spend time writing documentation (as well all know that takes forever), and make any changes that you feel are necessary.
This pull request adds the following public elements:
Number
- Parses a number given a specific format provided by thelexical
crate.number
- Which is just the constructor function.format
- A reexport oflexical::format
This pull request changes the the following:
InputRef::skip_bytes
to allow fornumber
to work withSliceInput
. I am admittedly not sure if this is the right call, but it seemed like the previous bound was unnecessarily strict.Questions:
Number
to requireI: StrInput
?skip_bytes
to requireStrInput
that I should be aware of?StrInput
?.