Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: setuptools deprecating test #1806

Closed
grawlinson opened this issue Nov 15, 2022 · 1 comment · Fixed by #1818
Closed

BUG: setuptools deprecating test #1806

grawlinson opened this issue Nov 15, 2022 · 1 comment · Fixed by #1818

Comments

@grawlinson
Copy link

What pyzmq version?

any

What libzmq version?

any

Python version (and how it was installed)

3.10

OS

Arch Linux

What happened?

No bug yet, but setuptools will be deprecating python setup.py test shortly. And from what I remember, pytest-runner isn't a viable replacement due to it using python setup.py test under the hood.

References:

Code to reproduce bug

No response

Traceback, if applicable

No response

More info

No response

@minrk
Copy link
Member

minrk commented Nov 15, 2022

We don't seem to use anything from setuptools test for setup.py test. We have our own TestCommand which inherits from the base Command, and is a simple wrapper to shell out to python -m pytest.

I'm not sure why we have that! But it doesn't seem to touch anything that's deprecated. We don't have a tests_require.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants