Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orders page sorting removed but infrastructure remains #6619

Open
scottcwilson opened this issue Jul 27, 2024 · 6 comments
Open

Orders page sorting removed but infrastructure remains #6619

scottcwilson opened this issue Jul 27, 2024 · 6 comments

Comments

@scottcwilson
Copy link
Sponsor Contributor

The orders page sorting was removed but orders.php lines 1252-1279 still set the unused variable $disp_order.

It might be nice to have a sort dropdown next to the order status filter. Or we could just remove this code.

@torvista
Copy link
Member

Sort by what?

@scottcwilson
Copy link
Sponsor Contributor Author

If you look at the code I referenced, you'll see the options. I'm not sure any of them are terribly useful though. It looks like it was modeled after the customer page sorting, but even back as far as 1.3.8, it wasn't fully implemented.

@torvista
Copy link
Member

Yes, I see. Personally I've never missed not having a sort.

@drbyte
Copy link
Member

drbyte commented Jul 29, 2024

The orders page sorting was removed

When?

@drbyte
Copy link
Member

drbyte commented Jul 29, 2024

It might be nice to have a sort dropdown next to the order status filter.

Sometimes expanding the filtering options is more advantageous than a "sort". Granted, we do have a search.

@scottcwilson
Copy link
Sponsor Contributor Author

The orders page sorting was removed

When?

I thought it had been but I looked waaaaay back and couldn't find it. So I guess this code has been there, unused, forever? Not strong on this, it's just a bit confusing if you're reading the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants