fix(tab-bar): prevent active tab from being hidden #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops. Forgot clippy... |
|
Sorry about another force push.. I wasn't fully happy with the solution since it was still not consistent and in certain widths not using up all possible space. The issue was that we can't really populate tabs and then collapse after. I thought about it and we should start from a state of collapsed left, middle, collapsed right and expand tabs while they fit. This current version is completely consistent from what I can tell! Now it should fully close #668 and #699. But it does not attempt to keep active bar in the middle. |
|
Okay, now the active tab should be kept in the middle. |
|
@prscoelho - this looks great! Thanks for your meticulous work on this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #668 (somewhat) and #699. The active bar won't disappear anymore, but which tabs render is still inconsistent. I think the only way to make it more consistent would be to calculate space required for the collapsed tabs beforehand and remove that amount before calling tabs_to_render.