Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zellij Needs a Proper Logging System #561

Closed
TheLostLambda opened this issue Jun 1, 2021 · 4 comments
Closed

Zellij Needs a Proper Logging System #561

TheLostLambda opened this issue Jun 1, 2021 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest For the hacktoberfest month help wanted Extra attention is needed mentored A maintainer will guide newcomers through implemention, offering guidance and feedback along the way

Comments

@TheLostLambda
Copy link
Member

TheLostLambda commented Jun 1, 2021

Zellij needs a central logging bus that captures the stderr from plugins, the client, and the server. Information coming over these channels should be tagged with it's location of origin (e.g. thread / plugin name) and timestamped.

Ideally, using dbg!() or something extraordinary similar with "just work", with the values being dbg!()ed appearing in the logs.

This is a mentored issue, so if you'd like to take this on, you can count on some extra help and guidance from some of our maintainers.

@TheLostLambda TheLostLambda added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed mentored A maintainer will guide newcomers through implemention, offering guidance and feedback along the way labels Jun 1, 2021
@qepasa
Copy link
Contributor

qepasa commented Jun 14, 2021

Looks like a cool issue. I'd like to give this one a go.

@TheLostLambda
Copy link
Member Author

Awesome! Do you have any particular approach in mind or do you need any help understanding the codebase? If you need anything, just let us know!

@qepasa qepasa mentioned this issue Jun 30, 2021
3 tasks
@qepasa
Copy link
Contributor

qepasa commented Jul 18, 2021

Some ideas for followup:

  • change logging level to more verbose when zellij is started with --debug parameter
  • custom log writer that would write to file with colors

@qballer qballer added the hacktoberfest For the hacktoberfest month label Sep 22, 2021
@imsnif
Copy link
Member

imsnif commented Sep 25, 2021

This has already implemented. Thanks @qepasa! if you want to make the followups into new issues that can be great.

@imsnif imsnif closed this as completed Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest For the hacktoberfest month help wanted Extra attention is needed mentored A maintainer will guide newcomers through implemention, offering guidance and feedback along the way
Projects
None yet
Development

No branches or pull requests

4 participants