Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hiding session-manager with Esc on New Session tab #3408

Open
cristiand391 opened this issue Jun 8, 2024 · 0 comments
Open

Support hiding session-manager with Esc on New Session tab #3408

cristiand391 opened this issue Jun 8, 2024 · 0 comments

Comments

@cristiand391
Copy link
Contributor

cristiand391 commented Jun 8, 2024

the session-manager supports Esc to hide itself except in New Session tab, I've checked the code don't see it calls hide_self like others handlers do (when it isn't in the welcome screen mode).

new-session handler:
https://github.com/zellij-org/zellij/blob/56baf0b13dfc177a095ae9b3267fe531d4453099/default-plugins/session-manager/src/main.rs#L246C1-L249C15

attach-to-session handler:
https://github.com/zellij-org/zellij/blob/56baf0b13dfc177a095ae9b3267fe531d4453099/default-plugins/session-manager/src/main.rs#L370C1-L377C19

resurrect-session handler:
https://github.com/zellij-org/zellij/blob/56baf0b13dfc177a095ae9b3267fe531d4453099/default-plugins/session-manager/src/main.rs#L423C1-L427C15

Unless this was intentional, it would be nice to have this behavior consistent in all 3 tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant