DumpScreen dumps current screen only, not full scrollback

[damanis]

Basic information

zellij --version: 0.39.2

uname -av: 5.15.0-91-generic #101~20.04.1-Ubuntu SMP Thu Nov 16 14:22:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Reproduction steps:

• Add to scroll section of config.kdl:

scroll {
    ...
    bind "a" { DumpScreen "/tmp/my-dump.txt"; }
}

• Run zellij
• ls -1R /etc
• Press Ctrl-s (switch to mode scroll), then a

Issue description

The scrollback has all ls -1R /etc output, but the file /tmp/my-dump.txt includes only lines from current screen. According documentation it should has all scrollback lines:

Dump the contents of the focused pane, including its entire scrollback, to the specified file.

EditScrollback puts all output to editor, but it blocks terminal. The goal is get entire output to editor.

[jalbertcruz]

In the version 0.40 this bug continues.

[Jesse-Millwood]

From this merged pull request: https://github.com/zellij-org/zellij/pull/1794/files

It looks like you need to provide an additional argument to indicate the full scroll back. I ran into this because I was using the cli action interface and have to do zellij action dump-screen --full ~/path/to/log.txt

I wonder if there is an optional argument now for DumpScreen that doesn't show in the docs kind of like how LaunchOrFocusPlugin has optional options?