Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theming idea is really bad #2933

Closed
ghost opened this issue Nov 13, 2023 · 2 comments
Closed

theming idea is really bad #2933

ghost opened this issue Nov 13, 2023 · 2 comments

Comments

@ghost
Copy link

ghost commented Nov 13, 2023

current approach "logically forces" users assign specific colors to a set of colors. we all know that it definitely isn't a correct way to theme an app!

themes {
    nord {
        fg "#D8DEE9"
        bg "#2E3440"
        black "#3B4252"
        red "#BF616A"
        green "#A3BE8C"
        yellow "#EBCB8B"
        blue "#81A1C1"
        magenta "#B48EAD"
        cyan "#88C0D0"
        white "#E5E9F0"
        orange "#D08770"
    }
}

all other apps apply the "label-based" theming approach which is much better and explicit to customize, i.e:

themes {
   nord {
        main_fg "#D8DEE9"
        main_bg "#2E3440"
        
        statusline_fg "#D8DEE9"
        statusline_bg "#88C0D0"
        
        current_selected_item_fg "#D8DEE9"
        current_selected_item_bg "#A3BE8C"
        
        // other elements and parts for ui
        // ...
    }
}
@ghost
Copy link
Author

ghost commented Nov 13, 2023

@imsnif, please check vim and vscode themes to know that i meant

@imsnif
Copy link
Member

imsnif commented Nov 13, 2023

Duplicate of #2297

Also: please don't @ me unless it's urgent or I have previously participated in the discussion. There's a lot going on this repository and I need to be able to prioritize.

@imsnif imsnif closed this as completed Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant