-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] - Implement kittys terminal graphics protocol #2814
Comments
FIY: On the yazi wiki, there's a fix to use it with tmux: https://github.com/sxyazi/yazi/wiki/Image-preview-within-tmux |
Is there a sense of the work required to implement this? |
Yes, but it's extremely slow on tmux for some reason. |
There's a plethora of users that want to enjoy images in their terminal and some terminal tools implement image support (image.nvim plugin for neovim, neorg plugin for neovim, a lot of file browsers, etc.). I almost never leave terminal and currently use tmux, image implementation in zellij would be a dealbreaker for me. |
I really want to see Zellij support kitty graphics protocol, which is currently the most complete and advanced. It supports Unicode placeholders, I think this could solve the stuttering issue in Zellij's Sixel implementation. Kitty protocol simply prints some escape sequence to the screen, and terminals that support that protocol display it as an image and accurately render the image position when scrolling. This process is transparent to Zellij, and it doesn't need to parse and understand the meaning of the protocol itself, making it efficient. I've just implemented Unicode placeholders for Yazi and tested it in kitty+tmux, it works well: kitty+tmux.mp4 |
@sxyazi I've also tested it under tmux and it kinda works, but everything is really buggy (overlapping images, preview not updating, etc.) for some reason. |
Yes, Zellij does not support it; this requires Zellij to provide support.
What are your Yazi version and tmux version? What terminal are you using? Please also do an |
Just came across this and thought I should chime in. I believe what's required on zellij's end is a Passthrough sequence (I don't know if such exists yet but I suspect not) i.e some something like this. No special handling of graphics control sequences should be required. This should be all that's required to get Kitty's virtual placements working, assuming Zellij already supports indexed- (and optionally, direct-) -color SGR sequences and passes them through as recieved. It'll also allow the use of other image/graphics protocols to a certain extent, particularly in full-screen (non-scrolling) applications. For full/proper support, specialized implementations/handling will be required but personally, I'd discourage that for a terminal multiplexer. |
This is also how this issue was solved with junegunn/fzf junegunn/fzf kitty image protocol passthrough fix He uses a regex to detect the terminal sequence for images then assigns a no-op function for the preview that allows the un-altered terminal sequence to passthrough to the terminal so that the image is rendered like normal. You can test this with: fd . ~/Pictures -e png | fzf --preview='kitty icat --clear --transfer-mode=memory --stdin=no --place=${FZF_PREVIEW_COLUMNS}x${FZF_PREVIEW_LINES}@0x0 {}' |
is this still being worked on? |
I don’t think anyone has started to implement this. Just been talking about ways in which it could be achieved |
It would be neat if zellij could use kitty terminal graphics to display images or other files. Tmux had a similar issue closed, it seems like they will not be implementing it. Zellij does provide support for sixels but this is a very old protocol with not much support from other applications.
The text was updated successfully, but these errors were encountered: