-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KDL layouts: problematic percentage sizes #1825
Comments
I'm issuing a fix for the 0% case. The other issue has been with us for a while and will require a much needed overhaul to our resizing system. The latter will also fix all the fixed pane issues. For now I'm afraid we're going to have to trust users on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
version: main, roughly 12d35bd
There are some relative sizes that can cause trouble:
Small sizes: 0% - (100/number of terminal lines)%
Upon loading this layout I get either:
Bye from zellij!
log shows:
This also happens with
size=0
Sizes summing > 100%
This opens zellij, but the last pane is only 1 line tall, and also resizing is kinda broken: The upper panes keep their original size if they still have vertical space. The first pane that exceeds the window height is resized, but fails to display its bottom pane frame:
![image](https://user-images.githubusercontent.com/15750438/196724001-c2f09995-c226-4085-95a2-8f82eec5b7e1.png)
![image](https://user-images.githubusercontent.com/15750438/196724198-60bbc1b3-ea81-4341-81fe-03ec43b37640.png)
When the window gets bigger, the extra space is not filled at all:
With four panes of size 50% I can even get a server crash if I try to close them (similar symptoms like #1821)
The text was updated successfully, but these errors were encountered: