Starship multi-line prompt doubles up when line wrapping

[imsnif]

I think this is an issue with the current implementation of line wrapping and should hopefully be fixed in the refactoring of the very same area in the code that I'm doing right now. @TheLostLambda, I'll ping you to give this another shot once it's done - thanks!

[imsnif]

Hey @TheLostLambda - I just pushed some fixes to main that might solve this issue. Could you give it a go?

[TheLostLambda]

Unfortunately I get a crash now 😢

[imsnif]

Hum... do you think I can reproduce this easily somehow?

[TheLostLambda]

Hmm, do you not have the same issue when working with the Starship prompt? I'm happy to do some more debugging later in the week (though the first part of it is quite busy!)

[imsnif]

Tbh, I think I had some issue with installing starship and never came back to it. :)
So, @alekspickle said he'd try his hand at this.

[alekspickle]

I use konsole and I think I localized it with and without starship installed.
I presume it is not even starship related.
I basically just divided window with ctrl + N a few times and voila.

with starship

without starship installed

It definitely related with multiple vertical split.

[imsnif]

I think these are actually 3 different errors, if I'm reading correctly? Original is "fragment out of bounds", second is "cursor out of bounds" and third is "unhandled csi", right?

[alekspickle]

Yeah but I guess first two share at least a way to repoduce.
it is multiple vertical split

[imsnif]

Yeah, for sure. I would guess that one has to do with us not limiting the width of new panes. If you feel like working on that, maybe we can open a new issue for it?

[imsnif]

Opened a new issue here: #21

[imsnif]

@TheLostLambda - I think I fixed this. The fix is in main, would you mind confirming when you have the chance?

[TheLostLambda]

Hey @imsnif ! Did you fix the crash or the double-line bug? I'm pretty sure I'm still getting the crash on master 😢 I can help do some more proper debugging if you'd like?

[TheLostLambda]

Both vertical and horizontal split are crashing for me at the moment with the same: thread 'screen' panicked at 'fragment out of bounds', src/terminal_pane/scroll.rs:62:80

[imsnif]

Oi, no - I fixed the double line bug. :O
I must admit I forgot about the crash. :)

So, normal starship prompt works ok but when you split the screen it crashes, or?

[TheLostLambda]

It seems to behave as long as I don't split anything or resize the window at least, yeah :)

[imsnif]

Right! So let's open a new issue for that. I'll take a look at it. Would you mind doing it? I think it would be easier for you to describe how to reproduce it.

[TheLostLambda]

No worries! Can do a bit later this evening :)

[imsnif]

Awesome, thanks!