Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When changing the theme inlay hint gets reseted. #4276

Open
1 task done
sheikalthaf opened this issue Jan 12, 2024 · 4 comments
Open
1 task done

When changing the theme inlay hint gets reseted. #4276

sheikalthaf opened this issue Jan 12, 2024 · 4 comments
Labels
defect [core label] editor Feedback for code editing, formatting, editor iterations, etc inlay hints stale Label used by `stale` action theme Feedback for theme configuration, accessibility, visual issues, etc

Comments

@sheikalthaf
Copy link

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

When inlay hint is on, trying to change the theme then inlay hint is getting reseted.

Environment

Zed: v0.119.6 (Zed Preview)
OS: macOS 14.1.0
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

@sheikalthaf sheikalthaf added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Jan 12, 2024
@JosephTLyons JosephTLyons added editor Feedback for code editing, formatting, editor iterations, etc theme Feedback for theme configuration, accessibility, visual issues, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jan 15, 2024
@JosephTLyons
Copy link
Collaborator

JosephTLyons commented Jan 15, 2024

cc @SomeoneToIgnore, @maxdeviant

@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
@maxdeviant
Copy link
Member

@sheikalthaf I can't seem to reproduce this.

What I tried:

  1. Enabled inlay hints
  2. Opened the theme selector
  3. Flipped through multiple themes and observed that the inlay hints updated accordingly with the color from the new theme.

@maxdeviant maxdeviant added the can't reproduce Issue that can't be reproduced (transient, invalid, etc) label Mar 12, 2024
@Moshyfawn
Copy link
Member

I can't seem to reproduce this.

@maxdeviant here you go:

zed-inlay-modal-toggle.mp4

Reproduction steps:

  1. Enable inlay hints using the editor action button in the toolbar.
  2. Press cmd-shift-p to open the Command Palette.
  3. Select theme selector: toggle.
  4. See the inlay behind disabled.

@maxdeviant maxdeviant reopened this Mar 12, 2024
@Moshyfawn Moshyfawn removed the can't reproduce Issue that can't be reproduced (transient, invalid, etc) label Mar 12, 2024
Copy link

Hi there! 👋
We're working to clean up our issue tracker by closing older issues that might not be relevant anymore. If you are able to reproduce this issue in the latest version of Zed, please let us know by commenting on this issue, and we will keep it open. If you can't reproduce it, feel free to close the issue yourself. Otherwise, we'll close it in 7 days.
Thanks for your help!

@github-actions github-actions bot added the stale Label used by `stale` action label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] editor Feedback for code editing, formatting, editor iterations, etc inlay hints stale Label used by `stale` action theme Feedback for theme configuration, accessibility, visual issues, etc
Projects
None yet
Development

No branches or pull requests

4 participants