Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issue with hidden connection warning #3050

Closed
paulGeoghegan opened this issue May 10, 2024 · 3 comments
Closed

Accessibility issue with hidden connection warning #3050

paulGeoghegan opened this issue May 10, 2024 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@paulGeoghegan
Copy link

Description

I have just started using nicegui and I really like it so far. I'm quite impressed with the native mode and the accessibility which a lot of other options lack. There is one weird thing so far however.
I'm blind so I use a screen reader.
When I open the native app this text appears down the bottom:

⚠️
Connection lost.Trying to reconnect...

I assume this text is meant to be hidden to users but it isn't to screen reader users.

@falkoschindler
Copy link
Contributor

Thank you so much for reaching out, @paulGeoghegan! Although we're aware of screen readers and the importance of accessibility, it's easy to overlook when not using them ourselves. So we really appreciate your feedback.

The "Connection lost" popup is meant to appear only when the connection to the server is lost. This is implemented setting the opacity from 0 to 1, which indeed isn't very screen reader friendly. I'm going to look into this and see if I can make it more accessible.

@falkoschindler falkoschindler added this to the 1.4.25 milestone May 10, 2024
@falkoschindler falkoschindler self-assigned this May 10, 2024
@falkoschindler falkoschindler added the bug Something isn't working label May 10, 2024
@paulGeoghegan
Copy link
Author

@falkoschindler perfect thanks so much.

@falkoschindler
Copy link
Contributor

I think I fixed the issue using the aria-hidden attribute as well as setting the CSS property "visibility" accordingly. The fading transition as well as the transition delay before showing the popup has been preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants