Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixes #176] Task: support GeoNode 4.3 #181

Merged
merged 3 commits into from
Jun 23, 2024
Merged

[Fixes #176] Task: support GeoNode 4.3 #181

merged 3 commits into from
Jun 23, 2024

Conversation

mwallschlaeger
Copy link
Contributor

Description

bumping GeoNode default version to 4.3.0 and geoserver corresponding. referenced to https://github.com/GeoNode/geonode/releases/tag/4.3.0

Type of Change

Please select the relevant option:

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • GeoNode Release Upgrade

Related Issue

If there is an existing issue related to this pull request, please reference it here.

closes #176 #172

Checklist

Please ensure that your pull request meets the following requirements:

  • The pull request is limited to one type (docs, feature, bug fix, etc.)
  • The pull request is as small as possible. Consider opening multiple pull requests instead of one large one.
  • The feature or bug fix has been discussed and documented in an issue beforehand.

Additional Notes

Any additional information or context regarding the pull request can be provided here.

Thank you for creating this pull request

@mwallschlaeger mwallschlaeger added this to the v1.2.0 milestone Jun 19, 2024
@mwallschlaeger mwallschlaeger self-assigned this Jun 19, 2024
ridoo
ridoo reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@ridoo ridoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also the following files to be updated:

@ridoo
Copy link
Contributor

ridoo commented Jun 20, 2024 •
edited
Loading

Starting via minikube gives the following error:

minikube kubectl -- -n geonode logs -f pod/geonode-nginx-86b679cf75-hhns5
/docker-entrypoint.sh: /docker-entrypoint.d/ is not empty, will attempt to perform configuration
/docker-entrypoint.sh: Looking for shell scripts in /docker-entrypoint.d/
/docker-entrypoint.sh: Launching /docker-entrypoint.d/10-listen-on-ipv6-by-default.sh
10-listen-on-ipv6-by-default.sh: info: /etc/nginx/conf.d/default.conf is not a file or does not exist
/docker-entrypoint.sh: Sourcing /docker-entrypoint.d/15-local-resolvers.envsh
/docker-entrypoint.sh: Launching /docker-entrypoint.d/20-envsubst-on-templates.sh
/docker-entrypoint.sh: Launching /docker-entrypoint.d/30-tune-worker-processes.sh
/docker-entrypoint.sh: Configuration complete; ready for start up
2024/06/20 09:46:07 [emerg] 1#1: host not found in upstream "geonode-geoserver" in /etc/nginx/conf.d/geonode.conf:54
nginx: [emerg] host not found in upstream "geonode-geoserver" in /etc/nginx/conf.d/geonode.conf:54

Kubernetes and Minikube versions:

k version --short
Flag --short has been deprecated, and will be removed in the future. The --short output will become the default.
Client Version: v1.27.4
Kustomize Version: v5.0.1
Server Version: v1.30.0

I could successfully start minikube with Kubernetes version v1.27.13.

EDIT: Not reproducable. See -> #182

@ridoo ridoo mentioned this pull request Jun 20, 2024
Closed
ridoo
ridoo requested changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@ridoo ridoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwallschlaeger could not reproduce the DNS issue anymore. After adjusting the version numbers in the mentioned locations you can go ahead and merge.

@mwallschlaeger mwallschlaeger force-pushed the issue_#176_Task_support_GeoNode_4.3 branch from 2fe02d5 to 9436087 Compare June 21, 2024 12:30
@ridoo ridoo merged commit 6d1eab7 into main Jun 23, 2024
3 checks passed
@ridoo ridoo deleted the issue_#176_Task_support_GeoNode_4.3 branch June 23, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ridoo ridoo ridoo approved these changes

Assignees

@mwallschlaeger mwallschlaeger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task: support GeoNode 4.3
2 participants
@mwallschlaeger @ridoo