Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducing SARE results #31

Open
saibr opened this issue Jan 31, 2022 · 0 comments
Open

Reproducing SARE results #31

saibr opened this issue Jan 31, 2022 · 0 comments

Comments

@saibr
Copy link

saibr commented Jan 31, 2022

Thank you for releasing the code. When reproducing SARE results, I am able to reproduce the results in your paper when I use the dot product based code, but not the original Euclidean distance. Are the results in your work based on the code for the dot product?

For sare_joint the difference between the Euclidean distance and the dot product is about 15% for R@1, for both Pitts250k and Tokyo 24/7, which seems very high to me. Did you experience this as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant