Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rocksdb 5.18 #28

Merged
merged 6 commits into from
Apr 29, 2019
Merged

Upgrade rocksdb 5.18 #28

merged 6 commits into from
Apr 29, 2019

Conversation

absolute8511
Copy link

@absolute8511 absolute8511 commented Apr 11, 2019

this fix #26

@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #28 into master will decrease coverage by <.01%.
The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   44.07%   44.06%   -0.01%     
==========================================
  Files         150      150              
  Lines       23077    23117      +40     
==========================================
+ Hits        10171    10187      +16     
- Misses      11234    11261      +27     
+ Partials     1672     1669       -3
Impacted Files Coverage Δ
node/raft.go 35.94% <0%> (ø) ⬆️
node/namespace.go 41.04% <0%> (-1.35%) ⬇️
node/node.go 32.11% <0%> (-0.31%) ⬇️
server/server.go 51.3% <0%> (-0.39%) ⬇️
raft/rocksdb_storage.go 74.36% <100%> (-0.08%) ⬇️
server/httpapi.go 19.64% <8.33%> (-0.28%) ⬇️
rockredis/t_zset.go 48.38% <80%> (+0.74%) ⬆️
node/ttl.go 35.15% <0%> (ø) ⬆️
transport/rafthttp/stream.go 80.78% <0%> (+0.65%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7d41d6...c125a60. Read the comment docs.

@absolute8511 absolute8511 merged commit ec24616 into master Apr 29, 2019
@absolute8511 absolute8511 deleted the upgrade-rocksdb-5.18 branch November 26, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rocksdb DeleteRange v2 should be merged to improve read and scan with many delete ranges
1 participant