Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YDS-#257] YdsText에 overflow 및 maxLines 속성 추가 #258

Merged
merged 5 commits into from
Feb 21, 2024

Conversation

taeheeL
Copy link
Contributor

@taeheeL taeheeL commented Feb 20, 2024

Summary

  • 무슨 이유로 코드를 변경했는지
  • 테스트 계획 또는 완료 사항
  • Soomsil V2 검색 결과 화면 구현 중에 필요하여 추가하였습니다.

Describe your changes

  • 변경 또는 추가된 코드
  • 관련 스크린샷
  • 기존 Compose Text를 참고해 속성을 추가했습니다.
  • 최소 라인의 기본값은 1 최대 라인의 기본 값은 Int.MAX_VALUE 입니다.

Issue

  • Issue number

To reviewers

  • 어떤 위험이나 장애가 발견되었는지
  • 어떤 부분에 리뷰어가 집중하면 좋을지
  • BasicText에도 기본 compose Text와 같은 방식으로 추가했는데, 확인 한번 부탁드립니다.
  • 당장 필요한 부분이라 YDS 재배포 과정이 필요할 것 같은데 어떻게 할까요?

@taeheeL taeheeL self-assigned this Feb 20, 2024
@taeheeL taeheeL added the enhancement New feature or request label Feb 20, 2024
cometj03
cometj03 previously approved these changes Feb 21, 2024
Copy link
Member

@cometj03 cometj03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진행하셔도 좋을 것 같아요 👍

versions.properties의 버전을 올리면 자동으로 배포됩니다!

@taeheeL
Copy link
Contributor Author

taeheeL commented Feb 21, 2024

그럼 이 pr에 versions.properties올려서 푸쉬하겠습니다! @cometj03

version 2.5.4 -> 2.5.5
@cometj03
Copy link
Member

흐음 저희 배포를 수동으로 할까요? 머지 될 때마다 배포하는 게 조금 불편하네요

@@ -1,2 +1,2 @@
versionName=2.5.4
versionName=2.5.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앞 pr이랑 겹쳐서 2.5.6으로 해주시면 감사하겠습니다..!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인을 못했었네요 죄송합니다 ㅎㅎ.. 다시 푸쉬 했습니다!

cometj03
cometj03 previously approved these changes Feb 21, 2024
Copy link
Contributor

@giovannijunseokim giovannijunseokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@taeheeL taeheeL merged commit 703db93 into develop Feb 21, 2024
1 check passed
@taeheeL taeheeL deleted the feature/tei/ydsoverflow branch February 21, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YdsText에 overflow 및 maxLines 속성 추가
3 participants