Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expiringdict for ring.dict(expire) #123

Open
youknowone opened this issue May 5, 2019 · 5 comments
Open

expiringdict for ring.dict(expire) #123

youknowone opened this issue May 5, 2019 · 5 comments

Comments

@youknowone
Copy link
Owner

youknowone commented May 5, 2019

https://pypi.org/project/expiringdict/

Instead of ExpirableDictStorage implementation, replacing dict to expringdict looks simpler and reasonable

@youknowone youknowone changed the title expiringdict for ring.dict(expire) ? expiringdict for ring.dict(expire) Jun 29, 2019
@seeeturtle
Copy link

@youknowone, i tried to use ExpiringDict but it seems PyPI is not following up the master branch.
the last release of PyPI is Sep, 2017.

i guess it's not a good idea to use expiringdict.

@youknowone
Copy link
Owner Author

Hello, thanks for trying to contribute about this issue.

By checking expiringdict commits in https://github.com/mailgun/expiringdict/commits/master, it seems there was not much changes since 2017. The changes also not looks like critical issues about the project. If there is not known issues about the project, I think this can be proof of stability and concreteness of the project. How do you think about it?

@seeeturtle
Copy link

seeeturtle commented Jul 19, 2019 via email

@youknowone
Copy link
Owner Author

I think normal dict is good enough for permanent cache. For now, we use different backend for permanent cache and expirable cache. we can keep the permanent one as bow and just replace expirable one to expiringdict. Please let me know if there is any concern I missed.

@seeeturtle
Copy link

Ok, I got it. Thanks for answering my questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants