-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using 'supportedDestinations' with watchOS app doesn't generate an 'Embed Watch Content' build phase #1463
Comments
I am also looking for an answer on this. The doc's aren't clear if |
Perhaps it is fixed with #1438 |
Hi, thank you for the doc update. I'll take a look at the issue. |
Looks like the following part is causing the issue. XcodeGen/Sources/XcodeGenKit/PBXProjGenerator.swift Lines 779 to 780 in 0301741
I think we can fix it by also checking if Let me know what you all think. I'll create a PR if this approach looks good. |
@tatsuky does this mean that it would skip |
@bcardarella By "it" do you mean:
If so - it will just skip adding the "Embed Watch Content" phase for the target. The After reading Apple's Configuring a multiplatform app - apparently the watchOS destination for the multiplatform apps is not supported at the moment. The destination is also unavailable (not showing up) for a multiplatform app on Xcode 15.3. ![]() Given this information & on second thought, we should maybe disallow the |
@tatsuky perhaps emmit a warning or error if it is included and point to this issue so understand why it isn't (yet) supported. Looking at the issue tracker and it seems to be a common question |
@tatsuky, I support the change to add the check for |
@yonaskolb Just to confirm, can we still add the changes you suggested, given Xcode 15.3 seemingly doesn't allow us to create multiplatform apps that contain the watchOS destination? (at least not on the UI, that is) Alternatively, I think we could consider it as an invalid configuration and have xcodegen error out like @bcardarella suggested. |
@tatsuky yes agree. That's what I meant by an error when |
OK, I'll work on the fix and open a PR one of these days |
I'm currently in the process of migrating my project specs from
platform
tosupportedDestinations
. According to the project spec, this should work for all target types:I've noticed when I configure my watch app target with
supportedDestinations
, XcodeGen no longer generates an 'Embed Watch Content' build phase for the iOS app. Here is an example:Is this a bug or intended behavior? Should I continue to use
platform
for my watchOS targets? Thank you!The text was updated successfully, but these errors were encountered: