From 0e29f7032897f2ebdd4c617910aa8ade74bc4b23 Mon Sep 17 00:00:00 2001 From: rockyxing Date: Thu, 4 Aug 2022 14:36:40 +0800 Subject: [PATCH] tools/biolatency: Simplify extension summary redundant logic (#4145) Extension summary logic seems a bit redundant, try to simplify it (total already be calculated by FACTOR replacement). --- tools/biolatency.py | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/tools/biolatency.py b/tools/biolatency.py index 6f7719054d0f..feeb3bc400b0 100755 --- a/tools/biolatency.py +++ b/tools/biolatency.py @@ -111,8 +111,6 @@ } delta = bpf_ktime_get_ns() - *tsp; - EXTENSION - FACTOR // store as histogram @@ -185,16 +183,15 @@ if args.extension: storage_str += "BPF_ARRAY(extension, ext_val_t, 1);" - bpf_text = bpf_text.replace('EXTENSION', """ + store_str += """ u32 index = 0; ext_val_t *ext_val = extension.lookup(&index); if (ext_val) { lock_xadd(&ext_val->total, delta); lock_xadd(&ext_val->count, 1); } - """) -else: - bpf_text = bpf_text.replace('EXTENSION', '') + """ + bpf_text = bpf_text.replace("STORAGE", storage_str) bpf_text = bpf_text.replace("STORE", store_str) @@ -309,15 +306,10 @@ def flags_print(flags): dist.print_log2_hist(label, "disk", disk_print) if args.extension: total = extension[0].total - counts = extension[0].count - if counts > 0: - if label == 'msecs': - total /= 1000000 - elif label == 'usecs': - total /= 1000 - avg = total / counts + count = extension[0].count + if count > 0: print("\navg = %ld %s, total: %ld %s, count: %ld\n" % - (total / counts, label, total, label, counts)) + (total / count, label, total, label, count)) extension.clear() dist.clear()