Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove testing dependencies from application templates #2341

Closed
samdark opened this issue Feb 6, 2014 · 13 comments
Closed

Remove testing dependencies from application templates #2341

samdark opened this issue Feb 6, 2014 · 13 comments
Milestone

Comments

@samdark
Copy link
Member

samdark commented Feb 6, 2014

Currently basic application has the following in dependencies:

"yiisoft/yii2-codeception": "*",
"codeception/codeception": "*",
"codeception/specify": "*",
"codeception/verify": "*",

It triggers pretty big download and isn't actually needed in lots of cases where the application is to be used.

I propose removing it from dependencies and instead putting it to readme.

Doing that we still need to keep tests running on travis.

@samdark samdark modified the milestone: 2.0 GA Feb 6, 2014
@Ragazzo
Copy link
Contributor

Ragazzo commented Feb 6, 2014

I am ok with this, but as for me i got my yii2-basic less then a minute, so it is more of internet provider settings.

@samdark
Copy link
Member Author

samdark commented Feb 6, 2014

Well, another issue is that you need 512 MB of RAM to install it.

@Ragazzo
Copy link
Contributor

Ragazzo commented Feb 6, 2014

not sure, could be so maybe, i have not measured this, on my pc i have 16GB, so such problems for me are just skiped. but as i said i am ok with this.

@qiangxue
Copy link
Member

qiangxue commented Feb 6, 2014

  • We should keep yiisoft/yii2-codeception in the dependency as it's very small.
  • We may then update tests/README.md and include instructions on how to install codecept via either phar or composer.
  • .travis.yml needs to be updated to install codeception.

@samdark
Copy link
Member Author

samdark commented Feb 6, 2014

Why keeping yiisoft/yii2-codeception if it cannot work without codeception itself?

@Ragazzo
Copy link
Contributor

Ragazzo commented Feb 6, 2014

Why keeping yiisoft/yii2-codeception if it cannot work without codeception itself?

it can, you can download phar or install via composer.

@qiangxue also note that we are using specify/verify that are not included in phar.

@samdark
Copy link
Member Author

samdark commented Feb 6, 2014

Makes sense.

@qiangxue
Copy link
Member

qiangxue commented Feb 6, 2014

also note that we are using specify/verify that are not included in phar.

Perhaps we should suggest @davert to include them in phar? Right now they depend on PHPUnit package. If they are required via composer, it means PHPUnit package will be installed while codeception phar already includes PHPUnit.

@Ragazzo
Copy link
Contributor

Ragazzo commented Feb 6, 2014

@qiangxue he is DavertMik ;) yes, we can, but i am not sure if it is a good way, @DavertMik want to exclude all unneeded dependencies from Codeception. But worth trying to ask :)

@DavertMik
Copy link
Contributor

Ok, I agree pretty much testing dependencies for basic application. Especially when not too many developers will be interested in testing from start.

Right now I work on codeception 2.0 which goes to master branch (as unstable development). I'm trying to do less BC breaks when possible, and last night I got everything back green on Travis, but still I should apologize for any issues that may happen, as you rely on the master branch. I promise to stabilize it before the Yii2 RC released.

specify can't be included into codecept.phar for 1.8 version, because in 1.8 Codeception requires PHP 5.3. But I was planning to it into 2.0 as it needs be 5.4. I think verify will be added as well.

Right now there is no phar package for Codeception 2.0. I'm going to build it when I have first release.

Also you may put codeception dependencies into the suggests section.

@yupe
Copy link
Contributor

yupe commented Feb 7, 2014

I think that we should include Codeception into yii2-codeception extension. In my project yii2-codeception is in "require-dev" section of composer.json and we also can install project with "--no-dev" option.

@samdark samdark closed this as completed in 77dae9a Feb 7, 2014
@Ragazzo
Copy link
Contributor

Ragazzo commented Feb 7, 2014

Section suggest has wrong format, also add docs to README.md under tests directory that first step should be php composer.phar require --dev "codeception/codeception: 1.8.*@dev" "codeception/specify: *" "codeception/verify: *"

@cebe cebe reopened this Feb 7, 2014
@cebe cebe added this to the 2.0 Beta milestone Feb 7, 2014
@samdark
Copy link
Member Author

samdark commented Feb 7, 2014

All fixed.

@samdark samdark closed this as completed Feb 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants