Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module container test #145

Closed
wants to merge 1 commit into from
Closed

Add module container test #145

wants to merge 1 commit into from

Conversation

yiiliveext
Copy link
Contributor

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌

@yiiliveext yiiliveext requested a review from a team September 2, 2020 09:11
@thenotsoft thenotsoft added the status:code review The pull request needs review. label Sep 2, 2020
@samdark samdark added the type:test Test label Sep 4, 2020
samdark
samdark reviewed Sep 4, 2020
View reviewed changes
tests/Unit/AbstractModuleContainerTest.php

abstract class AbstractModuleContainerTest extends TestCase
{
abstract public function createModuleContainer(array $rootDefinitions, array $moduleDefinitions): array;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there going to be multiple implementations?

tests/Unit/AbstractModuleContainerTest.php Show resolved Hide resolved
tests/Unit/ModuleContainerTest.php
public function createModuleContainer(array $rootDefinitions, array $moduleDefinitions): array
{
$compositeContainer = new CompositeContainer();
//$rootContainer = new Container($rootDefinitions, [], $compositeContainer);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just an example of a module container. We haven't any valid implementation now, so I wrote the abstract test.

@samdark
Copy link
Member

samdark commented Apr 20, 2021

This PR will be updated soon. Problems in tests are valid and to be solved.

@samdark samdark added status:under development Someone is working on a pull request. and removed status:code review The pull request needs review. labels Apr 20, 2021
@samdark samdark closed this Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark left review comments

Assignees

@yiiliveext yiiliveext

Labels
status:under development Someone is working on a pull request. type:test Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yiiliveext @samdark @thenotsoft