Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] use root NS specification for opcoded functions #14

Closed
wants to merge 1 commit into from
Closed

[minor] use root NS specification for opcoded functions #14

wants to merge 1 commit into from

Conversation

kalessil
Copy link

Q A
Is bugfix? no
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues n/a

@rob006
Copy link

rob006 commented Jan 30, 2018

I prefer to use imports for this - less noise in the code, and result should be the same.

// ...
use funtion count;

@SilverFire
Copy link
Member

Agreed with @rob006

@kalessil
Copy link
Author

kalessil commented Feb 5, 2018

@rob006 , @SilverFire : got it.

Currently, Php Inspections (EA Extended) doesn't support auto-importing for this case so I have to close the PR.

@kalessil kalessil closed this Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kalessil @rob006 @SilverFire