Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect stats from yii-demo #206

Open
samdark opened this issue Apr 4, 2021 · 5 comments
Open

Collect stats from yii-demo #206

samdark opened this issue Apr 4, 2021 · 5 comments
Labels
status:ready for adoption Feel free to implement this issue.

Comments

@samdark
Copy link
Member

samdark commented Apr 4, 2021

  1. How many services are requested per route?
  2. How many aren't defined in container and automatically resolved?
  3. How many sub-dependencies are per service?
@samdark samdark added the status:ready for adoption Feel free to implement this issue. label Apr 4, 2021
@yiiliveext
Copy link
Contributor

  1. How many services are requested per route?
  2. How many aren't defined in container and automatically resolved?
  3. How many sub-dependencies are per service?

This easy imlements with yii-debug.

@samdark
Copy link
Member Author

samdark commented Apr 4, 2021

We need to get these numbers once to better understand what may affect performance and what may not. That's one time thing.

@alamagus
Copy link

alamagus commented Jul 28, 2022

Any thoughts on having built-in support for opentelemetry, like, yiisoft/yii-otel?
https://github.com/open-telemetry/opentelemetry-php (it's not production ready yet though)
https://groups.google.com/g/php-fig/c/6Nm0ZQ1_hJA/m/Fxp6EPsODgAJ

@samdark
Copy link
Member Author

samdark commented Jul 28, 2022

@alamagus I don't think we are going to support it. Instead, I'd rely on community solutions for it.

@xepozz
Copy link
Contributor

xepozz commented Jul 28, 2022

Any thoughts on having built-in support for opentelemetry, like, yiisoft/yii-otel?
https://github.com/open-telemetry/opentelemetry-php (it's not production ready yet though)
https://groups.google.com/g/php-fig/c/6Nm0ZQ1_hJA/m/Fxp6EPsODgAJ

@alamagus Thanks for the information, but I think this issue is not about telemetry in general, but about some benchmarks in CI.
If you want to add Open Telemetry integration it would be nice to have as separated package that could be included into users apps.
Both yiisoft/demo and yiisoft/demo-api repos may be lab rats for these changes. Would you like to implement it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready for adoption Feel free to implement this issue.
Projects
None yet
Development

No branches or pull requests

4 participants