Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: gographics/imagick Loading
base: master
Choose a base ref
...
head repository: yext/imagick Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 178 files changed
  • 6 contributors

Commits on Feb 1, 2019

  1. Bazel support

    1. A download-build-imagemagick.sh script that automates downloading and
       building static libraries for ImageMagick and dependencies from source on
       MacOS and Linux/CentOS6.
    
    2. A Vagrantfile that defines 3 boxes for building ImageMagick static libraries
       from source, testing that the go tests work on linux, and verifying the
       resulting binary runs in production.
    
    3. The precompiled libraries resulting from the above steps, so that clients on
       either platform can use them without effort.
    
    4. Tweaks to magick_wand_test.go to match the current usage. Specific image
       formats are verified to be present, and tests for font support are disabled.
    
    5. #cgo directives in magick_wand.go so that the precompiled libraries are used
       by the Go command line tool as well. Also add a -Wno-ignored-attributes to
       suppress a noisy warning from include/magick/memory_.h:31
    Rob Figueiredo committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    7827fa8 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2019

  1. Support Go 1.13

    chilliams committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    b9756e8 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2019

  1. Merge pull request #1 from yext/go_version-1.13

    Support Go 1.13
    zhang3r committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    68056bf View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Added Ubuntu support by recompiling with -fPIE

    In order for the generated libraries to be linkable in Ubuntu and
    runnable in CentOS, they must be compiled as Position-Independent
    Executables (PIE). This is done by injecting the -fPIE cflag in when
    compiling ImageMagick. The updated object files in this commit were
    generated with this flag added.
    
    Additional changes were made to documentation and Vagrantfile
    in order to test building in Ubuntu, linking in Ubuntu via Bazel, and
    running the final binary in CentOS.
    
    The version number referenced in the README was also corrected to match
    the version downloaded/built in download-build-imagemagick.sh.
    atavakoliyext committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    3783100 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2 from yext/fix-fpie-issue

    Added Ubuntu support by recompiling with -fPIE
    atavakoliyext committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    d26c6f1 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. Upgrade ImageMagick to 6.9.11-55

    This involved the following changes:
    
    1. Upgrade libwebp to 1.1
    2. Add libltdl
    3. Patch wand/pixel-wand.h to include the PixelWand struct definition.
       It's instantiated in Go, and it's not possible to allocate an
       incomplete struct.
    
    Make some other small improvements:
    
    - Update rules_go to latest.
    - Add a .bazelrc with some helpful settings.
    - Add some helpful dev tips to README.
    - Patch download-build-imagemagick
    
    Tested by following the instructions in README.
    Rob Figueiredo committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    543ef14 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2023

  1. Create main.yml

    PhilipA20 committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    f5e636e View commit details
    Browse the repository at this point in the history
Loading