Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with :pf #41

Closed
jacobjwalters opened this issue Jul 12, 2021 · 3 comments
Closed

Crash with :pf #41

jacobjwalters opened this issue Jul 12, 2021 · 3 comments
Labels
bug Something isn't working insight wanted Extra attention is needed newbie friendly Good for new OwenDevs

Comments

@jacobjwalters
Copy link
Collaborator

Upon calling :pf f (a,b,c) = g a b c, pointfree' throws an exception and crashes the entire bot. This should be properly caught.

owenbot-exe: pointfree: not supported: PTuple () Boxed [PVar () (Ident () "a"),PVar () (Ident () "b"),PVar () (Ident () "c")]
CallStack (from HasCallStack):
error, called at ./Plugin/Pl/Parser.hs:8:14 in pointfree-1.1.1.8-I2W1iGuieXp7A9292pxyGI:Plugin.Pl.Parser

I had a peek at the source, and I can't immediately see any exception throwing (in fact, the function returns Maybe String, so I'm surprised we have this problem).

@jacobjwalters jacobjwalters added bug Something isn't working insight wanted Extra attention is needed newbie friendly Good for new OwenDevs labels Jul 12, 2021
@social-anthrax
Copy link
Collaborator

Is the error thrown due to the mishandling of the Maybe or within the function itself?

@jacobjwalters
Copy link
Collaborator Author

Within the function it seems, as it's a custom error thrown by pointfree.

Exceptions should be caught by the Command stuff (according to yuto), so it's doubly strange.

@social-anthrax
Copy link
Collaborator

Time to go open a PR with them I guess
That or it could be worth trying to catch any errors raised by that function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working insight wanted Extra attention is needed newbie friendly Good for new OwenDevs
Projects
None yet
Development

No branches or pull requests

2 participants