-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Number #896
Comments
@sils1297 can't you use current date in milliseconds for that?
|
@yegor256 that is a very high number and feels somewhat hacky, I'd rather prefer real build numbers. |
@sils1297 each "talk" (a Github issue, for example) in rultor has its own number, and each build inside the talk has a number as well. Thus, we have two numbers... We can expose them both to all scripts, like |
@yegor256 sounds good, I assume the build is not unique across talks though? I think people would prefer simplicity, i.e. a simple build number from which in the best case they even can generate an URL to the rultor log. (CircleCI does this.) |
@sils1297 yes, each build has a unique number and it's a combination of these two, for example, your build: So, a unique address of this build is |
@sils1297 but there is no guarantee that they will go consequentially :( |
@yegor256 so I guess we have no choice but use the good old time at least on short term. |
@sils1297 well, we can add a unique incremental number to the system, which will uniquely identify builds across the entire Rultor. It's not a big problem, but do we need this? Let's think.. How much difference will it have from good old |
FWIW, the ideal solution would be a number that is only unique per repository IMO. This would then be a real build number. Just make sure you use the right time, in some time zones theres summer/winter time and stuff that needs to be avoided. Other than that I see no big risks. |
@sils1297 attached this issue to milestone "2.0" (let me know if this is wrong) |
@yegor256 this is your task now,help us |
@yegor256 fyi we ended up using |
@alex-palevsky assign someone else pls |
@yegor256 30 points deducted from your rating |
@yegor256 right, I'll try to find someone else for this task |
@alex-palevsky this is postponed |
@original-brownbear got it, "postponed" label here |
@original-brownbear someone else will help in this task, no problem at all |
Job |
Hey,
we want to use rultor for deploying our project when stuff gets merged to master. However for that we need some unique ID that is guaranteed to be higher than the last time the action was done, some may call this a build number :) Your docs don't really state such a thing exist, at least I didn't find it.
We'd love to switch to rultor for such things, currently we're using CI which is very comfortable but lacks the "pre-merge-security" and simulating deployment steps on wip branches isn't really the same.
The text was updated successfully, but these errors were encountered: