Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two error messages on merge closed pull request #1007

Open
aistomin opened this issue Feb 15, 2016 · 7 comments
Open

Two error messages on merge closed pull request #1007

aistomin opened this issue Feb 15, 2016 · 7 comments
Labels

Comments

@aistomin
Copy link
Contributor

I've made some mistakes when was talking to Rultor and noticed a behaviour that is not clear to me. Maybe it's an expected behaviour, would be nice if somebody could clarify it to me.

Pull request where problem occurred: aistomin/jenkins-sdk#182

Questions:

  1. I sent Rultor two consiquent merge messages by mistake, why didn't Rultor just ignore the second message?
  2. Ok, Rultor interpreted the second message as a command inside already merged PR, why he sent me two error messages "The pull request is closed already, so I can't merge it" and "I'm sorry, I don't understand you :( ". One message I think is enough :)
@aistomin aistomin changed the title Two Rultor messages on merge closed pull request Two error messages on merge closed pull request Feb 15, 2016
@alex-palevsky
Copy link
Contributor

@yegor256 please pay attention to this issue (par.21)

@yegor256 yegor256 added the bug label Feb 19, 2016
@alex-palevsky
Copy link
Contributor

@aistomin since there is no milestone yet I set it to "2.0"

@alex-palevsky alex-palevsky added this to the 2.0 milestone Feb 21, 2016
@original-brownbear
Copy link
Contributor

@alex-palevsky this depends on #917.

@alex-palevsky
Copy link
Contributor

@alex-palevsky this depends on #917.

@original-brownbear ok, let's wait for #917

@original-brownbear
Copy link
Contributor

@alex-palevsky this is postponed.

@alex-palevsky
Copy link
Contributor

@alex-palevsky this is postponed.

@original-brownbear right, I added "postponed" label

@alex-palevsky
Copy link
Contributor

@alex-palevsky this is postponed.

@original-brownbear right, I'll try to find someone else for this task

@yegor256 yegor256 removed this from the 2.0 milestone Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants