Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement -kill command #2

Closed
yaroslav-gwit opened this issue Apr 20, 2023 · 1 comment
Closed

Implement -kill command #2

yaroslav-gwit opened this issue Apr 20, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@yaroslav-gwit
Copy link
Owner

yaroslav-gwit commented Apr 20, 2023

-stop is not sufficient if the underlying OS can't accept short ACPI signals (for example during a system boot, or if a VM is stuck in a reboot loop). For this purpose I'll add -kill command:

  • It will ignore the machine's "online" status, and will attempt to clean up everything regardless
  • After the -stop is used, new kill function will start a "process kill" loop and will prevent the VM from coming back to life (there are some edge cases, where bhyve revives the VM even after it was stopped and network interface removed, -kill will make sure VM stays down)
  • Sometimes it's useful to -kill a VM instantly, avoiding the delay that is involved in a graceful shutdown
@yaroslav-gwit yaroslav-gwit added the enhancement New feature or request label Apr 20, 2023
@yaroslav-gwit yaroslav-gwit self-assigned this Apr 20, 2023
@yaroslav-gwit
Copy link
Owner Author

yaroslav-gwit commented Apr 25, 2023

stop --force was implemented instead of kill. A bit more testing is required to confirm that it works as expected.

This issue will be closed now, but feel free to open a new one if you find any bugs in the stop --force.

@yaroslav-gwit yaroslav-gwit changed the title Create -kill command Implement -kill command Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant