Isolated Workspaces Updates #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdwain
commented
Mar 1, 2018
| Install only that package's dependencies, and do not hoist them to the rootDir. Install dependencies on other | ||
| workspaces from registry instead of using the local version. | ||
|
|
||
| It should still use the rootDir's lockfile since adding lockfiles for each workspace will cause conflicts | ||
| across workspaces. Since other workspaces will not be in the lockfile, it should determine their versions as if it was | ||
| installing without a lockfile (by taking the newest version that matches their semver). | ||
|
|
||
| #### Changes to current (non-isolated) behavior |
There was a problem hiding this comment.
deleting the dependency on install seems to happen automatically already, so it was unnecessary. With that, no existing commands needed changing.
|
Looks good, thanks @bdwain! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bestander I have some small changes I realized were necessary after beginning work on this.
rendered