Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Java 21 build #1

Merged
merged 1 commit into from
Dec 1, 2023
Merged

chore: Java 21 build #1

merged 1 commit into from
Dec 1, 2023

Conversation

fdelsert
Copy link
Contributor

Pattern matching for switch is no longer a preview feature in Java 21 : https://openjdk.org/projects/jdk/21/

@fdelsert
Copy link
Contributor Author

If you eliminate the use of sealed switch in future commits, I think that the target Java version can remain Java 20.
If so, feel free to decline this pull request.

@xyzsd
Copy link
Owner

xyzsd commented Dec 1, 2023

We shall change it to 21 for now, but I do think the next (1.0) version should target JDK20 / no preview features. Additional refactorings are on the way shortly.

@xyzsd xyzsd merged commit 648800e into xyzsd:main Dec 1, 2023
@xyzsd
Copy link
Owner

xyzsd commented Dec 1, 2023

and thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants