Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the Bigquery apostrophes to delimiter decription string not work #177

Closed
lmarqueto opened this issue Jan 6, 2023 · 3 comments
Closed
Assignees

Comments

@lmarqueto
Copy link

Describe the bug
In the Bigquery when we use apostrophes to delimiter description string in options make parse fail

To Reproduce
This fail
CREATE TABLE data.test ( col STRING OPTIONS(description='test') ) OPTIONS(description='test');
and this work

CREATE TABLE data.test ( col STRING OPTIONS(description="test") ) OPTIONS(description="test");

Expected behavior
Both statements should parsed

@xnuinside xnuinside self-assigned this Jan 7, 2023
@xnuinside
Copy link
Owner

@lmarqueto thanks for reporting the issue! I already have released fix in version 0.29.1 and added the test https://github.com/xnuinside/simple-ddl-parser/pull/179/files#diff-ff905774288e5cd43c5adcde46191c8990ae3fc1472fe5315344493aa946aade

@xnuinside
Copy link
Owner

I will close the issue, if needed something more - feel free to open the new one!

@lmarqueto
Copy link
Author

@xnuinside Thank you very much for your attention and for the super fast resolution 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants