Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple SERDEPROPERTIES fails #126

Closed
mikeskov opened this issue Apr 22, 2022 · 2 comments
Closed

Multiple SERDEPROPERTIES fails #126

mikeskov opened this issue Apr 22, 2022 · 2 comments

Comments

@mikeskov
Copy link

Describe the bug
Entering multiple key/value pairs in SERDEPROPERTIES causes parsing to fail and return empty

To Reproduce
This works:

ddl="CREATE TABLE `x` (`a` STRING) ROW FORMAT SERDE 'my_serde' WITH SERDEPROPERTIES ( 'key1'='value1' )"
DDLParser(ddl,normalize_names=True).run(output_mode="hql")

This doesn't:

ddl="CREATE TABLE `x` (`a` STRING) ROW FORMAT SERDE 'my_serde' WITH SERDEPROPERTIES ( 'key1'='value1', 'key2'='value2' )"
DDLParser(ddl,normalize_names=True).run(output_mode="hql")

Expected behavior
Multiple key/value pairs in SERDEPROPERTIES should in the row format properties dict.

@xnuinside
Copy link
Owner

@mikeskov hi, thanks for reporting the issue, will work on it

@xnuinside
Copy link
Owner

@mikeskov hi again! fix released with version 0.26.1(https://pypi.org/project/simple-ddl-parser/), test added - https://github.com/xnuinside/simple-ddl-parser/blob/main/tests/test_hql_output_mode.py#L2203 if will be anything new - feel free to open new issue :) and thanks for report one more time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants