Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CLUSTERED BY to HQL parser #103

Closed
swiatek25 opened this issue Jan 3, 2022 · 3 comments
Closed

Adding CLUSTERED BY to HQL parser #103

swiatek25 opened this issue Jan 3, 2022 · 3 comments

Comments

@swiatek25
Copy link

Would that be possible to add CLUSTERED BY to the parser for HQL dialect?

Do you have any contribution guide so I could follow some instructions and do it by myself?

Additional context

@xnuinside
Copy link
Owner

@swiatek25 you can add it by yourself - needed only to add test in test cases with query and make required changes in code, but it's requireded some wish to work with ply - https://github.com/dabeaz/ply . when just open PR - I will review.

anyway, I can add support for this, I''m not sure that I will be able to do it today, but maybe tomorrow

@swiatek25
Copy link
Author

Hi, thanks for the response. That would take some time for me (getting familiar with ply). If I could count on your contribution I would really appreciate. Thanks in advance.

@xnuinside
Copy link
Owner

@swiatek25 I released version 0.24.0 with support - https://pypi.org/project/simple-ddl-parser/. Tests added: https://github.com/xnuinside/simple-ddl-parser/blob/main/tests/test_hql_output_mode.py#L2006. If you will find any new issues or needed something to add - feel free to open new issue or PR. And thanks one more time for contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants