Delete expired KeyPackage, rotate KeyPackages #541
Conversation
|
For the CI issue, just run |
| openmls = { git = "https://github.com/Bren2010/openmls", rev = "3992d09" } | ||
| openmls_basic_credential = { git = "https://github.com/Bren2010/openmls", rev = "3992d09" } | ||
| openmls_rust_crypto = { git = "https://github.com/Bren2010/openmls", rev = "3992d09" } | ||
| openmls_traits = { git = "https://github.com/Bren2010/openmls", rev = "3992d09" } | ||
| prost = "^0.12" |
There was a problem hiding this comment.
Shouldn't a PR be put up against https://github.com/xmtp/openmls with any necessary changes here?
(Rather than changing the base repo on which we're using. )
Without more context here for why this change is necessary, I would advise on holding off on merging this until:
- It's clear here why we should switch to using Brendan's fork, or
- we wait for the changes to land in
xmtp/openmlsand we retain that dependency.
There was a problem hiding this comment.
There is a PR here: xmtp/openmls#20
The Cargo.toml here was just changed temporarily
ee291c5
to
85112a0
Compare
My idea was just to just leave all KeyPackages in storage until they expire, based on the thought that they might still be used. |
We still need to rotate the KeyPackage if there haven't been any Welcome messages processed in the last X months, but I'm not sure the best way to implement that check?