Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxVm: fix randomx_create_vm call #1872

Merged
merged 1 commit into from Oct 7, 2020
Merged

RxVm: fix randomx_create_vm call #1872

merged 1 commit into from Oct 7, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 6, 2020

randomx_create_vm requires either cache or dataset, but not both

randomx_create_vm requires either cache or dataset, but not both
@ghost
Copy link
Author

ghost commented Oct 6, 2020

Two and more instances of RxDataset with 1 GiB pages will have at least one allocated but not initialized cache.
That's a source of problem in #1871

@xmrig xmrig linked an issue Oct 7, 2020 that may be closed by this pull request
@xmrig xmrig added this to the v6 milestone Oct 7, 2020
@xmrig xmrig added the bug label Oct 7, 2020
@xmrig xmrig merged commit cf54c85 into xmrig:dev Oct 7, 2020
@ghost ghost deleted the fix_vm_create branch October 7, 2020 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in randomx.cpp:463 in version 6.3.4 and 6.3.5
2 participants