From 7cd20cfab648901288819c74026616a7328a130e Mon Sep 17 00:00:00 2001
From: Nikolay Borisenko <22616990+nvborisenko@users.noreply.github.com>
Date: Fri, 19 May 2023 12:13:36 +0300
Subject: [PATCH] [dotnet] Fix building errors of the solution in VS via
 isolating output path per project (#12063)

* Isolate bin output per project

* Ignore bin folder only for dotnet

---------

Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
---
 .gitignore                                         | 1 +
 dotnet/src/support/WebDriver.Support.csproj        | 4 ----
 dotnet/src/webdriver/WebDriver.csproj              | 4 ----
 dotnet/test/chrome/WebDriver.Chrome.Tests.csproj   | 9 +--------
 dotnet/test/common/WebDriver.Common.Tests.csproj   | 8 --------
 dotnet/test/edge/WebDriver.Edge.Tests.csproj       | 9 +--------
 dotnet/test/firefox/WebDriver.Firefox.Tests.csproj | 9 +--------
 dotnet/test/ie/WebDriver.IE.Tests.csproj           | 9 +--------
 dotnet/test/remote/WebDriver.Remote.Tests.csproj   | 9 +--------
 dotnet/test/safari/WebDriver.Safari.Tests.csproj   | 9 +--------
 dotnet/test/support/WebDriver.Support.Tests.csproj | 9 +--------
 11 files changed, 8 insertions(+), 72 deletions(-)

diff --git a/.gitignore b/.gitignore
index 3c41916c15b75..63e5176c32523 100644
--- a/.gitignore
+++ b/.gitignore
@@ -80,6 +80,7 @@ selenium.egg-info/
 third_party/java/jetty/jetty-repacked.jar
 *.user
 *.cache
+dotnet/**/bin/
 obj/
 *.opensdf
 *.suo
diff --git a/dotnet/src/support/WebDriver.Support.csproj b/dotnet/src/support/WebDriver.Support.csproj
index 01188a1174afa..15f9da3f3eec1 100644
--- a/dotnet/src/support/WebDriver.Support.csproj
+++ b/dotnet/src/support/WebDriver.Support.csproj
@@ -7,10 +7,6 @@
     <BuildSystem>visual-studio</BuildSystem>
   </PropertyGroup>
 
-  <PropertyGroup>
-    <OutputPath>..\..\..\build\cli\$(Configuration)\</OutputPath>
-  </PropertyGroup>
-
   <PropertyGroup>
     <AssemblyTitle>Selenium WebDriver Support</AssemblyTitle>
     <Description>Selenium WebDriver .NET Bindings support classes</Description>
diff --git a/dotnet/src/webdriver/WebDriver.csproj b/dotnet/src/webdriver/WebDriver.csproj
index 73b73a1b528d1..0edf505f522e1 100644
--- a/dotnet/src/webdriver/WebDriver.csproj
+++ b/dotnet/src/webdriver/WebDriver.csproj
@@ -6,10 +6,6 @@
     <RootNamespace>OpenQA.Selenium</RootNamespace>
   </PropertyGroup>
 
-  <PropertyGroup>
-    <OutputPath>..\..\..\build\cli\$(Configuration)\</OutputPath>
-  </PropertyGroup>
-
   <PropertyGroup>
     <AssemblyTitle>WebDriver</AssemblyTitle>
     <Description>Selenium WebDriver API .NET Bindings</Description>
diff --git a/dotnet/test/chrome/WebDriver.Chrome.Tests.csproj b/dotnet/test/chrome/WebDriver.Chrome.Tests.csproj
index c66bbc3b8f787..f5bf1e5cb0719 100644
--- a/dotnet/test/chrome/WebDriver.Chrome.Tests.csproj
+++ b/dotnet/test/chrome/WebDriver.Chrome.Tests.csproj
@@ -5,14 +5,6 @@
     <AssemblyName>WebDriver.Chrome.Tests</AssemblyName>
   </PropertyGroup>
 
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
-    <OutputPath>..\..\..\build\cli\Debug\</OutputPath>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
-    <OutputPath>..\..\..\build\cli\Release\</OutputPath>
-  </PropertyGroup>
-
   <ItemGroup>
     <Compile Remove="obj\**" />
     <EmbeddedResource Remove="obj\**" />
@@ -31,6 +23,7 @@
   </ItemGroup>
 
   <ItemGroup>
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
     <PackageReference Include="NUnit" Version="3.13.2" />
     <PackageReference Include="NUnit3TestAdapter" Version="3.16.1" />
   </ItemGroup>
diff --git a/dotnet/test/common/WebDriver.Common.Tests.csproj b/dotnet/test/common/WebDriver.Common.Tests.csproj
index 4f3116601345b..6578b8edcabb3 100644
--- a/dotnet/test/common/WebDriver.Common.Tests.csproj
+++ b/dotnet/test/common/WebDriver.Common.Tests.csproj
@@ -6,14 +6,6 @@
     <RootNamespace>OpenQA.Selenium</RootNamespace>
   </PropertyGroup>
 
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
-    <OutputPath>..\..\..\build\cli\Release\</OutputPath>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
-    <OutputPath>..\..\..\build\cli\Debug\</OutputPath>
-  </PropertyGroup>
-
   <ItemGroup>
     <Compile Remove="obj\**" />
     <EmbeddedResource Remove="obj\**" />
diff --git a/dotnet/test/edge/WebDriver.Edge.Tests.csproj b/dotnet/test/edge/WebDriver.Edge.Tests.csproj
index 163e4b55a9c75..ecee67f3234e5 100644
--- a/dotnet/test/edge/WebDriver.Edge.Tests.csproj
+++ b/dotnet/test/edge/WebDriver.Edge.Tests.csproj
@@ -5,14 +5,6 @@
     <AssemblyName>WebDriver.Edge.Tests</AssemblyName>
   </PropertyGroup>
 
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
-    <OutputPath>..\..\..\build\cli\Debug\</OutputPath>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
-    <OutputPath>..\..\..\build\cli\Release\</OutputPath>
-  </PropertyGroup>
-
   <ItemGroup>
     <Compile Remove="obj\**" />
     <EmbeddedResource Remove="obj\**" />
@@ -33,6 +25,7 @@
   </ItemGroup>
 
   <ItemGroup>
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
     <PackageReference Include="NUnit" Version="3.13.2" />
     <PackageReference Include="NUnit3TestAdapter" Version="3.16.1" />
   </ItemGroup>
diff --git a/dotnet/test/firefox/WebDriver.Firefox.Tests.csproj b/dotnet/test/firefox/WebDriver.Firefox.Tests.csproj
index b80409972dae7..7bbff9bcfa9e6 100644
--- a/dotnet/test/firefox/WebDriver.Firefox.Tests.csproj
+++ b/dotnet/test/firefox/WebDriver.Firefox.Tests.csproj
@@ -5,14 +5,6 @@
     <AssemblyName>WebDriver.Firefox.Tests</AssemblyName>
   </PropertyGroup>
 
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
-    <OutputPath>..\..\..\build\cli\Debug\</OutputPath>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
-    <OutputPath>..\..\..\build\cli\Release\</OutputPath>
-  </PropertyGroup>
-
   <ItemGroup>
     <Compile Remove="obj\**" />
     <EmbeddedResource Remove="obj\**" />
@@ -44,6 +36,7 @@
   </ItemGroup>
 
   <ItemGroup>
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
     <PackageReference Include="NUnit" Version="3.13.2" />
     <PackageReference Include="NUnit3TestAdapter" Version="3.16.1" />
   </ItemGroup>
diff --git a/dotnet/test/ie/WebDriver.IE.Tests.csproj b/dotnet/test/ie/WebDriver.IE.Tests.csproj
index 8226870b5f04c..10a6474bdd0e7 100644
--- a/dotnet/test/ie/WebDriver.IE.Tests.csproj
+++ b/dotnet/test/ie/WebDriver.IE.Tests.csproj
@@ -6,14 +6,6 @@
     <RootNamespace>OpenQA.Selenium.IE</RootNamespace>
   </PropertyGroup>
 
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
-    <OutputPath>..\..\..\build\cli\Debug\</OutputPath>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
-    <OutputPath>..\..\..\build\cli\Release\</OutputPath>
-  </PropertyGroup>
-
   <ItemGroup>
     <Compile Remove="obj\**" />
     <EmbeddedResource Remove="obj\**" />
@@ -32,6 +24,7 @@
   </ItemGroup>
 
   <ItemGroup>
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
     <PackageReference Include="NUnit" Version="3.13.2" />
     <PackageReference Include="NUnit3TestAdapter" Version="3.16.1" />
   </ItemGroup>
diff --git a/dotnet/test/remote/WebDriver.Remote.Tests.csproj b/dotnet/test/remote/WebDriver.Remote.Tests.csproj
index 80397cc86edb8..5be0c0804c850 100644
--- a/dotnet/test/remote/WebDriver.Remote.Tests.csproj
+++ b/dotnet/test/remote/WebDriver.Remote.Tests.csproj
@@ -5,14 +5,6 @@
     <AssemblyName>WebDriver.Remote.Tests</AssemblyName>
   </PropertyGroup>
 
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
-    <OutputPath>..\..\..\build\cli\Debug\</OutputPath>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
-    <OutputPath>..\..\..\build\cli\Release\</OutputPath>
-  </PropertyGroup>
-
   <ItemGroup>
     <Compile Remove="obj\**" />
     <EmbeddedResource Remove="obj\**" />
@@ -29,6 +21,7 @@
   </ItemGroup>
 
   <ItemGroup>
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
     <PackageReference Include="NUnit" Version="3.13.2" />
     <PackageReference Include="NUnit3TestAdapter" Version="3.16.1" />
   </ItemGroup>
diff --git a/dotnet/test/safari/WebDriver.Safari.Tests.csproj b/dotnet/test/safari/WebDriver.Safari.Tests.csproj
index 7d6e33b6c9c2c..fec22927dfa37 100644
--- a/dotnet/test/safari/WebDriver.Safari.Tests.csproj
+++ b/dotnet/test/safari/WebDriver.Safari.Tests.csproj
@@ -5,14 +5,6 @@
     <AssemblyName>WebDriver.Safari.Tests</AssemblyName>
   </PropertyGroup>
 
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
-    <OutputPath>..\..\..\build\cli\Debug\</OutputPath>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
-    <OutputPath>..\..\..\build\cli\Release\</OutputPath>
-  </PropertyGroup>
-
   <ItemGroup>
     <Compile Remove="obj\**" />
     <EmbeddedResource Remove="obj\**" />
@@ -30,6 +22,7 @@
   </ItemGroup>
 
   <ItemGroup>
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
     <PackageReference Include="NUnit" Version="3.13.2" />
     <PackageReference Include="NUnit3TestAdapter" Version="3.16.1" />
   </ItemGroup>
diff --git a/dotnet/test/support/WebDriver.Support.Tests.csproj b/dotnet/test/support/WebDriver.Support.Tests.csproj
index 96f2481cdc5ed..7841b09340444 100644
--- a/dotnet/test/support/WebDriver.Support.Tests.csproj
+++ b/dotnet/test/support/WebDriver.Support.Tests.csproj
@@ -5,14 +5,6 @@
     <AssemblyName>WebDriver.Support.Tests</AssemblyName>
   </PropertyGroup>
 
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
-    <OutputPath>..\..\..\build\cli\Debug\</OutputPath>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
-    <OutputPath>..\..\..\build\cli\Release\</OutputPath>
-  </PropertyGroup>
-
   <ItemGroup>
     <Compile Remove="obj\**" />
     <EmbeddedResource Remove="obj\**" />
@@ -29,6 +21,7 @@
   </ItemGroup>
 
   <ItemGroup>
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
     <PackageReference Include="Moq" Version="4.13.0" />
     <PackageReference Include="NUnit" Version="3.13.2" />
     <PackageReference Include="NUnit3TestAdapter" Version="3.16.1" />