From 46946e99b93cca649c9a8060d998d880d570f644 Mon Sep 17 00:00:00 2001 From: Nikolay Borisenko Date: Sat, 9 Dec 2023 00:02:22 +0300 Subject: [PATCH] [dotnet] Improve file logging code smell based on feedback from 13249 --- dotnet/test/common/Internal/Logging/FileLogHandlerTest.cs | 5 ----- dotnet/test/common/Internal/Logging/LogTest.cs | 1 - 2 files changed, 6 deletions(-) diff --git a/dotnet/test/common/Internal/Logging/FileLogHandlerTest.cs b/dotnet/test/common/Internal/Logging/FileLogHandlerTest.cs index 072582723b154..790f8ce0cb997 100644 --- a/dotnet/test/common/Internal/Logging/FileLogHandlerTest.cs +++ b/dotnet/test/common/Internal/Logging/FileLogHandlerTest.cs @@ -6,7 +6,6 @@ namespace OpenQA.Selenium.Internal.Logging { public class FileLogHandlerTest { - [Test] [TestCase(null)] [TestCase("")] public void ShouldNotAcceptIncorrectPath(string path) @@ -30,10 +29,6 @@ public void ShouldHandleLogEvent() Assert.That(File.ReadAllText(tempFile), Does.Contain("test message")); } - catch (Exception) - { - throw; - } finally { File.Delete(tempFile); diff --git a/dotnet/test/common/Internal/Logging/LogTest.cs b/dotnet/test/common/Internal/Logging/LogTest.cs index 037e94faefec6..b8bd96b7d8287 100644 --- a/dotnet/test/common/Internal/Logging/LogTest.cs +++ b/dotnet/test/common/Internal/Logging/LogTest.cs @@ -32,7 +32,6 @@ public void LoggerShouldEmitEvent() Assert.That(logEvent.Timestamp, Is.EqualTo(DateTimeOffset.Now).Within(100).Milliseconds); } - [Test] [TestCase(LogEventLevel.Trace)] [TestCase(LogEventLevel.Debug)] [TestCase(LogEventLevel.Info)]