-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artifact (Overflow) #88
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello! I am currently building an app where I need to display product images.
As the faded background does not fit our design, I used
dimColor: Colors.white
to remove it.After doing so, I noticed that Crop renders width*1 pixels either at the top or the bottom of the widget. This is really noticable with dimColor set to white.
This mostly occures when the image does not have the same aspect ratio as the space in which the widget is rendered.
In the example image below, the source image is a Portrait (dimensions 2592*3840 pixels), and needs to be shown in space no bigger then 300x400.
Very visible example with dim color white:
![image](https://private-user-images.githubusercontent.com/24845056/245805568-a0cba71b-c1f8-4d81-86da-5419ecbba9a9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI2NTM5NTQsIm5iZiI6MTcyMjY1MzY1NCwicGF0aCI6Ii8yNDg0NTA1Ni8yNDU4MDU1NjgtYTBjYmE3MWItYzFmOC00ZDgxLTg2ZGEtNTQxOWVjYmJhOWE5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODAzVDAyNTQxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJmMmE5NzJmZWZiYmI1MTAyYjg5ODBhY2M0OWM1ZWM0Mzc2MjIwZGFjMjgxODEzMzA4NDcxOWE2NGQxMWE0ZWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.fOnGNvUgEurw3_ZV00rUXuvI6z7rcih_zZgj2yThk6o)
Same can be seen with default dim:
![image](https://private-user-images.githubusercontent.com/24845056/245807019-2cfffeef-21f8-42d6-baf3-411f08cc0dce.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI2NTM5NTQsIm5iZiI6MTcyMjY1MzY1NCwicGF0aCI6Ii8yNDg0NTA1Ni8yNDU4MDcwMTktMmNmZmZlZWYtMjFmOC00MmQ2LWJhZjMtNDExZjA4Y2MwZGNlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODAzVDAyNTQxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY4MDA1NWVlNTkwOTY0MjAzZDYwZjVkNDFiZTczYjkyNjlhOGZiYTY0MDQwYzc1ODczMGE0ZTNlNGVkZGM0ZGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ERfgS1HmJNtNVC29dDYj06L3m7UzHaXTq426v1IVWmw)
Here is the code that created that widget:
![image](https://private-user-images.githubusercontent.com/24845056/245805773-683c34ad-b6f1-481f-b314-5401f6b15e68.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI2NTM5NTQsIm5iZiI6MTcyMjY1MzY1NCwicGF0aCI6Ii8yNDg0NTA1Ni8yNDU4MDU3NzMtNjgzYzM0YWQtYjZmMS00ODFmLWIzMTQtNTQwMWY2YjE1ZTY4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODAzVDAyNTQxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI2MGE1ODhhYzJkYjQ1MDJjZDJiZDQ4MGMyNGI4YmU2ZDJjMDdlYjdiNTBkZmNlODY1ZjQ5OTI0YWQyY2Q4YjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.oywr1BDUz3buUJ7kKkGFH95mAsnZg3l_493_tjq5CUA)
I have tried to understand how Crop works to fix it myself, but I couldnt find the cause.
The text was updated successfully, but these errors were encountered: