Support create/drop index with uppercase names #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quote index names in index operations to avoid issues with case sensitivity.
Postgres stores index names with uppercase characters in the `pg_index` catalog using the quoted version of the name. For example: ``` "idx_USERS_name" ``` whereas a lowercase index name would be stored as: ``` idx_users_name ``` This is different to how other object types are stored in their respective catalogs. For example, table names are stored in the `pg_class` catalog without quotes, regardless of whether they contain uppercase characters.
5defcf4
to
73cf6c8
Compare
exekias
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #355
Postgres stores index names with uppercase characters in the
pg_indexcatalog using the quoted version of the name. For example:whereas a lowercase index name would be stored as:
This is different to how other object types are stored in their respective catalogs. For example, table names are stored in the
pg_classcatalog without quotes, regardless of whether they contain uppercase characters.This makes it necessary to strip quotes from index names when retrieving them from the
pg_indexcatalog when building the internal schema representation.