Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All] Removal of interactive music playback #15

Open
xan1242 opened this issue Dec 5, 2022 · 3 comments
Open

[All] Removal of interactive music playback #15

xan1242 opened this issue Dec 5, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@xan1242
Copy link
Owner

xan1242 commented Dec 5, 2022

I'm considering removing the interactive music playback feature and I'll need to gather some thoughts and opinions on this matter...

The reasons why I'm considering it:

  • The advancements in modding in-game files had grown since this plugin was made (MPFmaster)
  • In its current form, it makes no sense. As soon as you modify the map file (mpf) parts of the original interactive music, this player automatically becomes invalid. This is because it relies on just playing back the samples instead of actually playing the music
  • It's a big, complicated piece of code that just complicates matters, so limiting the scope to the EA Trax Jukebox will make things MUCH easier
  • Removes the need for the "installer" which just extracts the samples

While it was cool to see the in-game dialogs control external utilities and make BASS play samples, I don't think it's worth keeping.

There is a possibility where I keep it, and that is only and only if someone manages to:

  • Make an entirely custom Pathfinder player
  • Or maybe, make this into a dumb sample player (but this would mean re-extracting the samples every time you modify something, kinda like what it is now)

As a feature, keeping it as-is I could also do (and just disabling it) but during the process of simplification, I might break it.

@alexpado
Copy link

Hi,

So this means that we won't have pursuit music anymore ? This would be a massive lost to me tbh.

I love the fact I can just put my custom music for the races & open world and when entering a pursuit, the cool chase music starts.

@xan1242
Copy link
Owner Author

xan1242 commented Dec 12, 2022

No, this simply means that the standard player (SndStream) would play it normally instead of BASS. You wouldn't lose the actual functionality. In fact, I'd argue it's more flexible this way.

@xan1242 xan1242 added the enhancement New feature or request label Dec 12, 2022
@alexpado
Copy link

Well, that's okay with me, having a lot of files extracted from the game for "nothing" isn't ideal, I have to agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants