Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal average notebooks maintanance #633

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Conversation

lee1043
Copy link
Collaborator

@lee1043 lee1043 commented Apr 1, 2024

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@lee1043 lee1043 marked this pull request as ready for review April 1, 2024 23:13
@lee1043 lee1043 self-assigned this Apr 1, 2024
@lee1043 lee1043 added type: docs Updates to documentation Type: Documentation labels Apr 1, 2024
@tomvothecoder
Copy link
Collaborator

Thanks for this quick PR, Jiwoo! I will review it this week.

@tomvothecoder
Copy link
Collaborator

Hey @lee1043, can you also review climatology-and-departures.ipynb?

@lee1043
Copy link
Collaborator Author

lee1043 commented Apr 4, 2024

Hey @lee1043, can you also review climatology-and-departures.ipynb?

I confirmed that it is working well as is with xcdat 0.6.1.

@tomvothecoder
Copy link
Collaborator

Thanks @lee1043 for this PR. I formatted the plot code in temporal-average.ipynb and updated the author and last updated info in climatology-and-departures.ipynb.

I will now merge this PR!

@tomvothecoder tomvothecoder merged commit b835032 into main Apr 16, 2024
5 checks passed
@tomvothecoder tomvothecoder deleted the 589-doc-reviews_temporal branch April 16, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs Updates to documentation Type: Documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants