Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deprecation]: add_bounds accepting boolean arg in open_dataset() and open_mfdataset() #607

Closed
tomvothecoder opened this issue Feb 16, 2024 · 1 comment

Comments

@tomvothecoder
Copy link
Collaborator

xcdat/xcdat/dataset.py

Lines 57 to 59 in 94271f1

.. deprecated:: v0.6.0
``add_bounds`` boolean arguments (True/False) are being deprecated.
Please use either a list (e.g., ["X", "Y"]) to specify axes or ``None``.

xcdat/xcdat/dataset.py

Lines 148 to 150 in 94271f1

.. deprecated:: v0.6.0
``add_bounds`` boolean arguments (True/False) are being deprecated.
Please use either a list (e.g., ["X", "Y"]) to specify axes or ``None``.

xcdat/xcdat/dataset.py

Lines 621 to 641 in 94271f1

# TODO: Boolean (`True`/`False`) will be deprecated after v0.6.0.
if add_bounds is True:
add_bounds = ["X", "Y"]
warnings.warn(
(
"`add_bounds=True` will be deprecated after v0.6.0. Please use a list "
"of axis strings instead (e.g., `add_bounds=['X', 'Y']`)."
),
DeprecationWarning,
stacklevel=2,
)
elif add_bounds is False:
add_bounds = None
warnings.warn(
(
"`add_bounds=False` will be deprecated after v0.6.0. Please use "
"`add_bounds=None` instead."
),
DeprecationWarning,
stacklevel=2,
)

@tomvothecoder
Copy link
Collaborator Author

This is closed now since v0.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant