-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: open_dataset should handle missing bounds on ORCA grid more gracefully #284
Comments
Thank you for reporting this - I was able to reproduce this issue, which is now fixed in #278. I believe the goal is to produce a minor release in the next week with this fix. I will ping this thread when that is done. |
@jypeter - I updated to the main branch and tried your code and did not hit any issues opening the dataset – so this is resolved. I think the plan is to do a "patch release" in the next week to address this issue and a few others. @tomvothecoder - is that timeline correct? |
@pochedls You're correct, v0.3.1 (patch release) will be out in the next week. I'll make sure to keep our devs and testers posted. |
Thanks! I will update to the new version when it is available |
What happened?
[ Problem initially reported by @oliviermarti ]
I opened a file with data specified on the ORCA grid (one of the ORCA grids... but the problem would probably be the same for data on any non rectilinear grid), with no bounds available in the file and got a long traceback instead of a friendly warning
Generating a file that will reproduce the traceback
Get a clean IPSL
areacello
file from ESGF. This file can be opened without any problem withopen_dataset
wget https://vesg.ipsl.upmc.fr/thredds/fileServer/cmip6/CMIP/IPSL/IPSL-CM6A-LR/piControl/r1i2p1f1/Ofx/areacello/gn/v20190319/areacello_Ofx_IPSL-CM6A-LR_piControl_r1i2p1f1_gn.nc
Remove the references to the bounds, and remove the bounds variables
Reproducing the long traceback
Open the file with cdms2 and open_dataset
We can get rid of the traceback by overriding the default value of
add_bounds
What did you expect to happen?
I expect a behavior that will not frighten the user away!
It was not too hard for me to identify what the problem was, and find the
add_bounds=False
option, but you can't really expect that from a casual user or beginning intern who has only read an example notebook.open_dataset
should be able to detect this missing data/information and print a nice warning (and suggest theadd_bounds=False
workaround)Minimal Complete Verifiable Example
Relevant log output
No response
Anything else we need to know?
No response
Environment
The text was updated successfully, but these errors were encountered: