-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE]: Rename spatial_avg.py
to spatial.py
#206
Comments
Hey @pochedls, let me know what you think about this. |
I like this a lot. |
@tomvothecoder I think this is ideal, you may want median, min, max, ..., operations in addition to average so more general axes/spatial and time time_coordinate/temporal is a smart move. Just thinking aloud, I wonder if vertical would be folded into axes, or would be its own class? @pochedls has the arbitrary index discussion come up anywhere, so what I mean is captured in CDAT/cdat#1288 - this very well maybe already a core part of xarray |
Is your feature request related to a problem?
While working on #107, I noticed that I was adding temporal functions/methods to
temporal_avg.py
that weren't directly related to theTemporalAverageAccessor
class. For example, theTemporalAverageAccessor.center_times()
should actually just be a standalone function that lives in the.py
module.I ended up renaming the file from
temporal_avg.py
totemporal.py
to store all temporal related functions and classes.If we want to group functionality based on axes/dimensions, we should also rename
spatial_avg.py
tospatial.py
.Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: