Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modules] Polluted manifest in successive build:manifest calls #863

Open
5 tasks done
Timeraa opened this issue Jul 26, 2024 · 0 comments
Open
5 tasks done

[modules] Polluted manifest in successive build:manifest calls #863

Timeraa opened this issue Jul 26, 2024 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@Timeraa
Copy link
Contributor

Timeraa commented Jul 26, 2024

Describe the bug

Just noticed that in dev mode if you change a file like the background.ts in the demo extension the build:manifest hook of the new auto-icons module sends the icons property found console log which is due to the manifest.icons being filled out by the module the first dev run but the build:manifestGenerated hook should always get the "clean" manifest only the generated steps at that point in time

Reproduction

cd packages/wxt-demo
pnpm dev
# Save entrypoints/background.ts and you'll see the auto-icon warnings

Steps to reproduce

  1. Run dev in the demo extension
  2. Notice no "icons property found" log
  3. Update background.ts
  4. Notice "icons property found" log

System Info

System:
    OS: macOS 14.5
    CPU: (8) arm64 Apple M1 Pro
    Memory: 217.91 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.15.1 - /usr/local/bin/node
    npm: 10.7.0 - /usr/local/bin/npm
    pnpm: 8.15.9 - /usr/local/bin/pnpm
    bun: 1.1.1 - ~/.bun/bin/bun
  Browsers:
    Safari: 17.5
  npmPackages:
    wxt: workspace:* => 0.19.0

Used Package Manager

pnpm

Validations

@Timeraa Timeraa added the pending-triage Someone (usually a maintainer) needs to look into this to see if it's a bug label Jul 26, 2024
@aklinker1 aklinker1 added bug Something isn't working and removed pending-triage Someone (usually a maintainer) needs to look into this to see if it's a bug labels Jul 27, 2024
@aklinker1 aklinker1 changed the title WXT Module system bug [modules] Polluted manifest in successive build:manifest calls Aug 15, 2024
@aklinker1 aklinker1 added this to the v1.0 milestone Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants