Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch runtime exceptions in low-level crypto #283

Open
petrdvorak opened this issue Sep 2, 2019 · 2 comments
Open

Catch runtime exceptions in low-level crypto #283

petrdvorak opened this issue Sep 2, 2019 · 2 comments
Assignees

Comments

@petrdvorak
Copy link
Member

In several places in code (for example, when decoding private/public keys from bytes), we currently catch regular exceptions and not the runtime exceptions. These can occur, however, for example in case byte array contains invalid key data.

We should evaluate and catch runtime exceptions and rethrow our own exception type.

However, we are opening the issue based on debugging with our customer. Please consider if this is a good step and feel free to just close the issue in case you find that the current behavior is sufficient

@romanstrobl
Copy link
Member

This issue will have to wait for the next release.

@romanstrobl
Copy link
Member

This issue will have to wait for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants